Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug][slang] Fix recursive property negation check bug #1143

Merged
merged 1 commit into from
Oct 5, 2024
Merged

[bug][slang] Fix recursive property negation check bug #1143

merged 1 commit into from
Oct 5, 2024

Conversation

likeamahoney
Copy link
Contributor

Fix a check of illegal recursive property negation example from LRM which currently are not processed by slang:

module m;
    property prop_always(p);
        p and (1'b1 |=> prop_always(p));
    endproperty

    property illegal_recursion_1(p);
        not prop_always(not p);
    endproperty

endmodule

@codecov Codecov
Copy link

codecov bot commented Oct 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (85f61c6) to head (d40abbe).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1143   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files         191      191           
  Lines       47802    47804    +2     
=======================================
+ Hits        45304    45306    +2     
  Misses       2498     2498
Files with missing lines Coverage Δ
source/ast/expressions/MiscExpressions.cpp 94.21% <100.00%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f61c6...d40abbe. Read the comment docs.

@MikePopoloski MikePopoloski merged commit e85f944 into MikePopoloski:master Oct 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@likeamahoney @MikePopoloski @YanChurkin2018